feat(inspect): refs
#1489
Open
feat(inspect): refs
#1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
reviewed
Aug 21, 2025
| /// Returns the iceberg schema of the refs table. | ||
| pub fn schema(&self) -> crate::spec::Schema { | ||
| let fields = vec
There was a problem hiding this comment.
Is there any value in adding docs for each field?
emkornfield
reviewed
Aug 21, 2025
| Arc::new(max_snapshot_age_in_ms.finish()), | ||
| ])?; | ||
|
|
||
| Ok(stream::iter(vec![Ok(batch)]).boxed()) |
There was a problem hiding this comment.
I don't expect Refs to be particularly large, but is there a reason to not make this an actual stream that can read back the data incrementally (seems like it would be not that much more effort).
emkornfield
reviewed
Aug 21, 2025
| ], | ||
| min_snapshots_to_keep: PrimitiveArray<Int32> | ||
| [ | ||
| null, |
There was a problem hiding this comment.
for this and max_snapshot_age_in_ms, it seems like it would be good to have test coverage when the value is present, to differentiate tags from branchs
emkornfield
reviewed
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Subtask for #823
What changes are included in this PR?
Adds a
refstable to theinspectAre these changes tested?
Added a unit test.
I am pretty terrible at rust so far but think it is generally valuable to start implementing things here so we can roll wheels for the python implementation. Hoping to learn!